[PATCH] D159418: Move CallInst::CreateFree to IRBuilderBase

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/examples/BrainF/BrainF.cpp:131
   //call free(i8 *%arr)
-  CallInst::CreateFree(ptr_arr, endbb)->insertInto(endbb, endbb->end());
+  builder->SetInsertPoint(endbb->getTerminator());
+  builder->CreateFree(ptr_arr);
----------------
This doesn't look right to me: At this point the terminator is not inserted yet, so this should be inserting at endbb->end() as before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159418/new/

https://reviews.llvm.org/D159418