[llvm] 48987fb - [llvm][MC] Remove [[nodiscard]] from WithMarkup constructor

[David Spickett via llvm-commits]

Author: David Spickett
Date: 2023-09-04T15:05:07Z
New Revision: 48987fb8cc844667c6ee2a315140cb8f3d817fc1

URL: https://github.com/llvm/llvm-project/commit/48987fb8cc844667c6ee2a315140cb8f3d817fc1
DIFF: https://github.com/llvm/llvm-project/commit/48987fb8cc844667c6ee2a315140cb8f3d817fc1.diff

LOG: [llvm][MC] Remove [[nodiscard]] from WithMarkup constructor

This is causing a lot of warnings with older compilers and
errors for -Werror builders downstream.

I'm removing it until we can decide a good way to do this,
as it does seem important that this class not be discarded
given it controls formatting.

Added: 
    

Modified: 
    llvm/include/llvm/MC/MCInstPrinter.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/MC/MCInstPrinter.h b/llvm/include/llvm/MC/MCInstPrinter.h
index e7fe9cc0051edb2..8c628256eecf404 100644
--- a/llvm/include/llvm/MC/MCInstPrinter.h
+++ b/llvm/include/llvm/MC/MCInstPrinter.h
@@ -97,7 +97,7 @@ class MCInstPrinter {
 
   class WithMarkup {
   public:
-    [[nodiscard]] WithMarkup(raw_ostream &OS, Markup M, bool EnableMarkup,
+    WithMarkup(raw_ostream &OS, Markup M, bool EnableMarkup,
                              bool EnableColor);
     ~WithMarkup();