[PATCH] D157540: [JITLink][AArch32] Fixes for initial AArc32 backend

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 4 07:05:29 PDT 2023


sgraenitz added a comment.

In D157540#4636960 <https://reviews.llvm.org/D157540#4636960>, @sgraenitz wrote:

> So, the `Thumb_Jump24` relocation is the one that supports conditional branches and `Thumb_Call` is the one that should have this check

Just now I see that this is the bit that sets `NoBlx` for `Thumb_Call` and there is nothing to check here! We can simply remove the entire `LoBitConditional` check including the `FixupInfo` field :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157540/new/

https://reviews.llvm.org/D157540



More information about the llvm-commits mailing list