[PATCH] D159162: [llvm] Add assembly syntax highlighting

[Danila Malyutin via Phabricator via llvm-commits]

danilaml added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:100
+  public:
+    WithMarkup(raw_ostream &OS, Markup M, bool EnableMarkup, bool EnableColor);
+    ~WithMarkup();
----------------
jroelofs wrote:
> maybe this should be `[[nodiscard]]`
`[[nodiscard]]` on constructors is a C++20 feature, even though it works on older compilers (like gcc 7.4 we claim to support), it still produces an annoying (especially if you compile with -Werror) warning. Just wanted to mention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159162/new/

https://reviews.llvm.org/D159162