[llvm] e2e6846 - [RISCV] Use isNullConstant (NFC)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 4 00:31:47 PDT 2023


Author: Kazu Hirata
Date: 2023-09-04T00:31:38-07:00
New Revision: e2e68468f5ed5d9694f94045fb1d7ce591a80531

URL: https://github.com/llvm/llvm-project/commit/e2e68468f5ed5d9694f94045fb1d7ce591a80531
DIFF: https://github.com/llvm/llvm-project/commit/e2e68468f5ed5d9694f94045fb1d7ce591a80531.diff

LOG: [RISCV] Use isNullConstant (NFC)

Added: 
    

Modified: 
    llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index 096d25a16c4b00c..8449bd136704344 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -12906,12 +12906,10 @@ static bool combine_CC(SDValue &LHS, SDValue &RHS, SDValue &CC, const SDLoc &DL,
   // shift can be omitted.
   // Fold setlt (sra X, N), 0 -> setlt X, 0 and
   // setge (sra X, N), 0 -> setge X, 0
-  if (auto *RHSConst = dyn_cast<ConstantSDNode>(RHS.getNode())) {
-    if ((CCVal == ISD::SETGE || CCVal == ISD::SETLT) &&
-        LHS.getOpcode() == ISD::SRA && RHSConst->isZero()) {
-      LHS = LHS.getOperand(0);
-      return true;
-    }
+  if (isNullConstant(RHS) && (CCVal == ISD::SETGE || CCVal == ISD::SETLT) &&
+      LHS.getOpcode() == ISD::SRA) {
+    LHS = LHS.getOperand(0);
+    return true;
   }
 
   if (!ISD::isIntEqualitySetCC(CCVal))


        


More information about the llvm-commits mailing list