[PATCH] D159399: [RISCV] Only emit .option when extension is supported

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 3 22:45:01 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:261
       static_cast<RISCVTargetStreamer &>(*OutStreamer->getTargetStreamer());
+  RTS.emitDirectiveOptionPush();
+
----------------
Don't we only need this when we call `emitDirectiveOptionArch` later? Can we use the same `if`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159399/new/

https://reviews.llvm.org/D159399



More information about the llvm-commits mailing list