[PATCH] D159399: [RISCV] Only emit .option when extension is supported

[Piyou Chen via Phabricator via llvm-commits]

BeMg updated this revision to Diff 555653.
BeMg added a comment.

Refactor the emitDirectiveOptionPush, emitDirectiveOptionArch and emitDirectiveOptionPop in RISCVAsmPrinter::runOnMachineFunction


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159399/new/

https://reviews.llvm.org/D159399

Files:
  llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
  llvm/test/CodeGen/RISCV/riscv-func-target-feature.ll


Index: llvm/test/CodeGen/RISCV/riscv-func-target-feature.ll
===================================================================
--- llvm/test/CodeGen/RISCV/riscv-func-target-feature.ll
+++ llvm/test/CodeGen/RISCV/riscv-func-target-feature.ll
@@ -35,10 +35,10 @@
   ret void
 }
 
-; CHECK: .option push
+; CHECK-NOT: .option push
 define void @test5() "target-features"="+unaligned-scalar-mem" {
 ; CHECK-LABEL: test5
-; CHECK: .option pop
+; CHECK-NOT: .option pop
 entry:
   ret void
 }
Index: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
+++ llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
@@ -88,8 +88,8 @@
   void emitEndOfAsmFile(Module &M) override;
 
   void emitFunctionEntryLabel() override;
-  void emitDirectiveOptionArch();
-  bool isSameAttribute();
+  bool emitDirectiveOptionArch();
+  bool isSameSupportedAttribute();
 
 private:
   void emitAttributes();
@@ -252,9 +252,14 @@
   return false;
 }
 
-void RISCVAsmPrinter::emitDirectiveOptionArch() {
+bool RISCVAsmPrinter::emitDirectiveOptionArch() {
+  if (isSameSupportedAttribute())
+    return false;
+
   RISCVTargetStreamer &RTS =
       static_cast<RISCVTargetStreamer &>(*OutStreamer->getTargetStreamer());
+  RTS.emitDirectiveOptionPush();
+
   SmallVector<RISCVOptionArchArg> NeedEmitStdOptionArgs;
   const MCSubtargetInfo &MCSTI = *TM.getMCSubtargetInfo();
   for (const auto &Feature : RISCVFeatureKV) {
@@ -270,26 +275,35 @@
   }
   if (!NeedEmitStdOptionArgs.empty())
     RTS.emitDirectiveOptionArch(NeedEmitStdOptionArgs);
+
+  return true;
 }
 
-bool RISCVAsmPrinter::isSameAttribute() {
+bool RISCVAsmPrinter::isSameSupportedAttribute() {
   const MCSubtargetInfo &MCSTI = *TM.getMCSubtargetInfo();
-  return MCSTI.getFeatureBits() == STI->getFeatureBits();
+  for (const auto &Feature : RISCVFeatureKV) {
+    if (STI->hasFeature(Feature.Value) == MCSTI.hasFeature(Feature.Value))
+      continue;
+
+    if (!llvm::RISCVISAInfo::isSupportedExtensionFeature(Feature.Key))
+      continue;
+
+    return false;
+  }
+  return true;
 }
 
 bool RISCVAsmPrinter::runOnMachineFunction(MachineFunction &MF) {
   STI = &MF.getSubtarget<RISCVSubtarget>();
   RISCVTargetStreamer &RTS =
       static_cast<RISCVTargetStreamer &>(*OutStreamer->getTargetStreamer());
-  if (!isSameAttribute()) {
-    RTS.emitDirectiveOptionPush();
-    emitDirectiveOptionArch();
-  }
+
+  bool NeedEmitOptionArch = emitDirectiveOptionArch();
 
   SetupMachineFunction(MF);
   emitFunctionBody();
 
-  if (!isSameAttribute())
+  if (NeedEmitOptionArch)
     RTS.emitDirectiveOptionPop();
   return false;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D159399.555653.patch
Type: text/x-patch
Size: 2672 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230904/995dfffd/attachment.bin>