[PATCH] D157615: [ExtendLifetimes][1/4] Add "disable-post-ra" function attribute to disable the post-regalloc scheduler

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Do we need to register this attribute somewhere, in a .td file or something, to ensure it's discoverable by other people performing maintenance?

As we're adding an attribute, https://www.youtube.com/watch?v=6bmlqtjSPFw comes to mind ('2021 LLVM Dev Mtg "Please Stop Adding Attributes"'), but it sounds like we're not covered by that argument, not the least because we're not changing visible behaviours. Possibly a (bikeshed warning) more abstract name like "prioritize-debuggability" that's then interpreted by the post-ra scheduler would be better. No strong opinion from me.

Otherwise lgtm with Orlando's comments addressed (this should run just the single pass ideally)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157615/new/

https://reviews.llvm.org/D157615