[PATCH] D159179: [MC][ELF] Don't emit .note.GNU-stack sections on Solaris

Fri Sep 1 02:15:02 PDT 2023

ro added inline comments.

================
Comment at: llvm/test/CodeGen/X86/execstack.ll:9
+; CHECK-GNUSTACK: .section	".note.GNU-stack","", at progbits
+; CHECK-NOGNUSTACK-NOT: .section	".note.GNU-stack","", at progbits
----------------
MaskRay wrote:
> I know that Solaris has alternative section syntax? 
> 
> Perhaps `; CHECK-NOGNUSTACK-NOT: .section	".note.GNU-stack"` is better
It's true that the Solaris/SPARC and x86 native assemblers have differences in assembler syntax (considerable, like `#progbits` for the section type, and especially for the section flags on SPARC, minor on x86), but the `llc` output always uses gas syntax as accepted by the integrated assembler, so we can rely on that.  I'll therefore leave the check as is.

`clang` on Solaris doesn't support external assemblers right now (not even `gas`).  I may change that at some point, but it's low priority.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159179/new/

https://reviews.llvm.org/D159179