[PATCH] D159179: [MC][ELF] Don't emit .note.GNU-stack sections on Solaris

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 14:16:04 PDT 2023


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/X86/execstack.ll:9
+; CHECK-GNUSTACK: .section	".note.GNU-stack","", at progbits
+; CHECK-NOGNUSTACK-NOT: .section	".note.GNU-stack","", at progbits
----------------
I know that Solaris has alternative section syntax? 

Perhaps `; CHECK-NOGNUSTACK-NOT: .section	".note.GNU-stack"` is better


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159179/new/

https://reviews.llvm.org/D159179



More information about the llvm-commits mailing list