[PATCH] D159162: [llvm] Add assembly syntax highlighting
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 1 00:55:46 PDT 2023
jhenderson accepted this revision.
jhenderson added a comment.
Looks reasonable to me, although it's been a while since I last looked at this sort of area.
================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1240
uint64_t Val = MI->getOperand(OpNum).getImm();
- O << markup("<imm:") << "#0x";
+ WithMarkup M = markup(O, Markup::Immediate);
+ O << "#0x";
----------------
Just making sure I fully follow here: this lis essentially setting the markup to `Immediate` for the rest of the function, whereas the cases like in `printShifter` below just do it for the sequence of `<<` commands?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159162/new/
https://reviews.llvm.org/D159162
More information about the llvm-commits
mailing list