[PATCH] D159162: [llvm] Add assembly syntax highlighting

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 23:42:15 PDT 2023

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM. I think @jhenderson may have some opinions.

`llvm/docs/CommandGuide/llvm-mc.rst` needs updating.

Comment at: llvm/test/MC/Disassembler/AArch64/colored.txt:6
+# CHECK:      b.ne	#20
+0x00 0x7c 0x00 0x13
JDevlieghere wrote:
> MaskRay wrote:
> > I wonder whether this is sufficient to cover changes? Things like `printImmSVE` seem uncovered?
> Since the patch uses the same mechanism for emitting markup annotations and colors, I don't see the need to duplicate the testing for the two. The latter is (at least partially) covered by `marked-up.txt`. If we want to make sure every instruction type is covered, then the markup annotations are a much better way to do so: they're much easier to read and write and they are supported on all platforms (unlike ANSI escape codes). 



More information about the llvm-commits mailing list