[PATCH] D157871: IR: Add llvm.exp10 intrinsic

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:423
+                   RTLIB::EXP10_F80, RTLIB::EXP10_F128, RTLIB::EXP10_PPCF128));
+}
+
----------------
kpn wrote:
> I assume this is clang-format's formatting?
Yes


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6400
     case Intrinsic::cos:       Opcode = ISD::FCOS;       break;
+    case Intrinsic::exp10:     Opcode = ISD::FEXP10;     break;
     case Intrinsic::floor:     Opcode = ISD::FFLOOR;     break;
----------------
kpn wrote:
> This is different from exp and exp2. Is the limited precision stuff not needed or doesn't make sense?
It could follow it, but it's an additional optimization that can be done separately. Plus as far as I can tell, this is only enabled with a cl::opt which I didn't know existed so the utility seems marginal


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157871/new/

https://reviews.llvm.org/D157871