[PATCH] D157871: IR: Add llvm.exp10 intrinsic

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added a comment.

This looks good. If the limited precision stuff isn't needed then I'll sign off on it.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:423
+                   RTLIB::EXP10_F80, RTLIB::EXP10_F128, RTLIB::EXP10_PPCF128));
+}
+
----------------
I assume this is clang-format's formatting?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6400
     case Intrinsic::cos:       Opcode = ISD::FCOS;       break;
+    case Intrinsic::exp10:     Opcode = ISD::FEXP10;     break;
     case Intrinsic::floor:     Opcode = ISD::FFLOOR;     break;
----------------
This is different from exp and exp2. Is the limited precision stuff not needed or doesn't make sense?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157871/new/

https://reviews.llvm.org/D157871