[PATCH] D159179: [MC][ELF] Don't emit .note.GNU-stack sections on Solaris

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 01:50:35 PDT 2023


ro marked an inline comment as done.
ro added inline comments.


================
Comment at: llvm/lib/MC/MCAsmInfoELF.cpp:28
+    return nullptr;
+  else
+    return Ctx.getELFSection(".note.GNU-stack", ELF::SHT_PROGBITS, 0);
----------------
MaskRay wrote:
> The prevailing style is to omit `else` here
I tend to forget, it seems...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159179/new/

https://reviews.llvm.org/D159179



More information about the llvm-commits mailing list