[PATCH] D159179: [MC][ELF] Don't emit .note.GNU-stack sections on Solaris

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

This needs a test. We can create a file similar to `test/CodeGen/X86/segmented-stacks.ll`, but with just a Linux target triple and a Solaris target triple.



================
Comment at: llvm/lib/MC/MCAsmInfoELF.cpp:28
+    return nullptr;
+  else
+    return Ctx.getELFSection(".note.GNU-stack", ELF::SHT_PROGBITS, 0);
----------------
The prevailing style is to omit `else` here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159179/new/

https://reviews.llvm.org/D159179