[PATCH] D159157: [test][HWASAN] Precommit -hwasan-inline-fast-path-checks tests

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:587-592
+  InlineFastPath =
+      (ClInlineFastPathChecks.getNumOccurrences()
+           ? ClInlineFastPathChecks
+           : !(TargetTriple.isAndroid() ||
+               TargetTriple.isOSFuchsia())); // These platforms may prefer less
+                                             // inlining to reduce binary size.
----------------
fmayer wrote:
> I'm not a huge fan of different defaults per platform, wouldn't it be easier to just specify this for the platforms where you want this enabled?
I think it should be default, and I am just giving android time to investigate.

How about I land as is and soon after we remove exceptions, so it would be easy to bisect/revert if it's not good enough for android.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159157/new/

https://reviews.llvm.org/D159157