[PATCH] D159157: [test][HWASAN] Precommit -hwasan-inline-fast-path-checks tests

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 10:27:30 PDT 2023


fmayer added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:587-592
+  InlineFastPath =
+      (ClInlineFastPathChecks.getNumOccurrences()
+           ? ClInlineFastPathChecks
+           : !(TargetTriple.isAndroid() ||
+               TargetTriple.isOSFuchsia())); // These platforms may prefer less
+                                             // inlining to reduce binary size.
----------------
I'm not a huge fan of different defaults per platform, wouldn't it be easier to just specify this for the platforms where you want this enabled?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159157/new/

https://reviews.llvm.org/D159157



More information about the llvm-commits mailing list