[PATCH] D134282: [CGP] Add generic TargetLowering::shouldAlignPointerArgs() implementation

Wed Aug 30 12:31:04 PDT 2023

hubert.reinterpretcast added a comment.

In D134282#4628792 <https://reviews.llvm.org/D134282#4628792>, @efriedma wrote:

> getOrEnforceKnownAlignment has been doing similar modifications for a long time.  I guess I can see an argument that we should try to avoid alignment modifications for all globals after isel has run for any global.  Not sure what, exactly, that implies for the latest point it's legal to modify a global.
>
> We could try to move the optimization much earlier, like into the InferAlignment pass proposed in D158529 <https://reviews.llvm.org/D158529>.

I was just informed that @stefanp is away until some time next week. I am hoping to get his input on the importance of trying to get to a "better state" (both in general and for the specific case of the current optimization).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134282/new/

https://reviews.llvm.org/D134282