[PATCH] D134282: [CGP] Add generic TargetLowering::shouldAlignPointerArgs() implementation

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Whether it's a FunctionPass doesn't really matter; despite the "layering violation", there aren't any datastructures that actually care.  getOrEnforceKnownAlignment has been doing similar modifications for a long time.  I guess I can see an argument that we should try to avoid alignment modifications for all globals after isel has run for any global.  Not sure what, exactly, that implies for the latest point it's legal to modify a global.

We could try to move the optimization much earlier, like into the InferAlignment pass proposed in D158529 <https://reviews.llvm.org/D158529>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134282/new/

https://reviews.llvm.org/D134282