[PATCH] D159080: [mlir][ArmSME] Fix get_tile_id type in zero lowering

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

> I think this op is a bit clunky and could be simplified by returning the element type of the tile rather than an int representing the bitwidth, or perhaps just the 2-D scalable vector type this is extracted from, but that's a slightly move involved refactor.

Which Op are you referring to `arm_sme.zero`? `arm_sme.cast_tile_to_vector`?



================
Comment at: mlir/test/Dialect/ArmSME/tile-zero-masks.mlir:6
 
+// This test verifies the 8-bit tile mask operand of the zero intrinsic zeroes
+// the correct tiles. Both integer and floating-point datatypes are checked.
----------------
How is "8-bit" relevant here? What's meant to be 8-bit?


================
Comment at: mlir/test/Dialect/ArmSME/tile-zero-masks.mlir:9
+
 // -----
 
----------------
[nit] DELETME


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159080/new/

https://reviews.llvm.org/D159080