[PATCH] D158004: llvm-nm ignore the Import symbol file for the --export-symbol option.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 01:38:35 PDT 2023


jhenderson added a comment.

Okay, thanks for the comments. I was trying to see if there was a sensible middle ground that would satisfy both my concerns and those of @MaskRay, but I don't think there really is at this point. Please could you revert to the previous llvm-nm implementation and drop the `AIXImportFile` stuff (make sure to address the test comments too). Sorry for the churn.

I may have some comments on the older style, but I'll wait for the revert to happen, along with any tweaks you feel you need to make before I try to explain them. I'll make sure to review this as prompty as I can once you've made that revert, so that you aren't held up any further.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158004/new/

https://reviews.llvm.org/D158004



More information about the llvm-commits mailing list