[PATCH] D158004: llvm-nm ignore the Import symbol file for the --export-symbol option.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D158004#4621107 <https://reviews.llvm.org/D158004#4621107>, @DiggerLin wrote:

> @jhenderson , I would greatly appreciate your thoughts on the possibility of using the implement  proposed in https://reviews.llvm.org/D158004?id=552000 for the patch.

FWIW https://reviews.llvm.org/D158004?id=552000 looks good to me. I'll remove my "request changes" status now so that you don't need to wait on me if @jhenderson thinks fine:)



================
Comment at: llvm/test/tools/llvm-nm/XCOFF/export-symbols.test:58
+# RUN: echo "#!" > imp.txt
+# RUN: llvm-nm --export-symbols imp.txt 2>&1 | FileCheck --allow-empty --implicit-check-not={{.}} %s
+
----------------
`# RUN: llvm-nm --export-symbols imp.txt 2>&1 | count 0`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158004/new/

https://reviews.llvm.org/D158004