[PATCH] D158791: [runtimes] Add a mechanism to use cache files for a runtimes build

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 23:37:11 PDT 2023


phosek added a comment.

The fragments like https://github.com/llvm/llvm-project/blob/main/clang/cmake/caches/Fuchsia-stage2.cmake#L132-L184 and in particular https://github.com/llvm/llvm-project/blob/main/clang/cmake/caches/Fuchsia-stage2.cmake#L186-L289 have gotten quite unwieldy so I was already thinking about breaking those up into separate cache files and this feature is going to be needed so thank you!

The open question is if we should try and encourage developers towards using separate caches to the point where we can eventually completely deprecate and remove the support for passthrough or we want to be maintaining both forever?

Regarding the argument handling, I thought about alternatives but haven't come up with anything better. I have a question regarding the name though, we generally avoid the `CMAKE_` prefixed variables to potential (future) collisions (for example for CMake starts using `CMAKE_CACHES` in the future). Perhaps we should call this something like `LLVM_CACHE_FILES` or just `CACHE_FILES` for simplicty?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158791/new/

https://reviews.llvm.org/D158791



More information about the llvm-commits mailing list