[PATCH] D159053: [RISCV] Support select/merge like ops for fp16 vectors when only have Zvfhmin

Jianjian Guan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 20:26:37 PDT 2023


jacquesguan marked an inline comment as done.
jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:13907
+    // Early lower splat_vector (fp16 0) to vmv.v.i when we have only have
+    // Zvfhmin to avoid failed promotion.
+    if (isNullFPConstant(N->getOperand(0)) && VT.isVector() &&
----------------
craig.topper wrote:
> I'm not sure what "failed promotion" means
I rewrite this comment, it should be a bit more clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159053/new/

https://reviews.llvm.org/D159053



More information about the llvm-commits mailing list