[PATCH] D158913: [RISCV] Add a cross basic block VXRM write insertion pass.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 11:44:05 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertWriteVXRM.cpp:56
+
+  static VXRMInfo getUnknown() {
+    VXRMInfo Info;
----------------
eopXD wrote:
> Can we have a static singleton of `VXRMInfo` whose `State` is `Unknown`?
I think it'd like to keep it this way. It's the same in VSETVLIInfo. I'd need to add a new constructor in order to be to create the singleton in the unknown state.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158913/new/

https://reviews.llvm.org/D158913



More information about the llvm-commits mailing list