[PATCH] D158949: [LTO] Simplify internalize logic. NFC
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 28 09:49:36 PDT 2023
MaskRay marked an inline comment as done.
MaskRay added inline comments.
================
Comment at: llvm/lib/LTO/LTO.cpp:472
+ // Non-exported objects with external linkage can be internalized.
+ if (GlobalValue::isExternalLinkage(S->linkage())) {
+ S->setLinkage(GlobalValue::InternalLinkage);
----------------
tejohnson wrote:
> Nit: remove braces
Ah, there are two statements in the body (with one `continue;`):)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158949/new/
https://reviews.llvm.org/D158949
More information about the llvm-commits
mailing list