[PATCH] D158949: [LTO] Simplify internalize logic. NFC
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 28 09:12:42 PDT 2023
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
Thanks for cleaning this up, I agree it is easier to follow with the restructuring. lgtm.
================
Comment at: llvm/lib/LTO/LTO.cpp:472
+ // Non-exported objects with external linkage can be internalized.
+ if (GlobalValue::isExternalLinkage(S->linkage())) {
+ S->setLinkage(GlobalValue::InternalLinkage);
----------------
Nit: remove braces
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158949/new/
https://reviews.llvm.org/D158949
More information about the llvm-commits
mailing list