[PATCH] D158944: [MC] Remove comment no longer useful

Brad Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 26 14:08:48 PDT 2023


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3891c8d23e41: [MC] Remove comment no longer useful (authored by brad).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158944/new/

https://reviews.llvm.org/D158944

Files:
  llvm/lib/MC/MCAsmInfo.cpp


Index: llvm/lib/MC/MCAsmInfo.cpp
===================================================================
--- llvm/lib/MC/MCAsmInfo.cpp
+++ llvm/lib/MC/MCAsmInfo.cpp
@@ -64,19 +64,6 @@
     SupportsExtendedDwarfLocDirective = DwarfExtendedLoc == Enable;
   if (UseLEB128Directives != cl::BOU_UNSET)
     HasLEB128Directives = UseLEB128Directives == cl::BOU_TRUE;
-
-  // FIXME: Clang's logic should be synced with the logic used to initialize
-  //        this member and the two implementations should be merged.
-  // For reference:
-  // - Solaris always enables the integrated assembler by default
-  //   - SparcELFMCAsmInfo and X86ELFMCAsmInfo are handling this case
-  // - Windows always enables the integrated assembler by default
-  //   - MCAsmInfoCOFF is handling this case, should it be MCAsmInfoMicrosoft?
-  // - MachO targets always enables the integrated assembler by default
-  //   - MCAsmInfoDarwin is handling this case
-  // - Generic_GCC toolchains enable the integrated assembler on a per
-  //   architecture basis.
-  //   - The target subclasses for AArch64, ARM, and X86 handle these cases
   UseIntegratedAssembler = true;
   ParseInlineAsmUsingAsmParser = false;
   PreserveAsmComments = true;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158944.553763.patch
Type: text/x-patch
Size: 1219 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230826/1e0c2d63/attachment.bin>


More information about the llvm-commits mailing list