[llvm] 3891c8d - [MC] Remove comment no longer useful

Brad Smith via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 26 14:08:36 PDT 2023


Author: Brad Smith
Date: 2023-08-26T17:03:30-04:00
New Revision: 3891c8d23e41c97815b49d947459daac541f1f97

URL: https://github.com/llvm/llvm-project/commit/3891c8d23e41c97815b49d947459daac541f1f97
DIFF: https://github.com/llvm/llvm-project/commit/3891c8d23e41c97815b49d947459daac541f1f97.diff

LOG: [MC] Remove comment no longer useful

Remove a comment block regarding IAS. The comment is out of sync with the
current status and I don't think such a comment block is necessary anymore.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D158944

Added: 
    

Modified: 
    llvm/lib/MC/MCAsmInfo.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/MC/MCAsmInfo.cpp b/llvm/lib/MC/MCAsmInfo.cpp
index 71564ba9d5a181..1675e24301dc69 100644
--- a/llvm/lib/MC/MCAsmInfo.cpp
+++ b/llvm/lib/MC/MCAsmInfo.cpp
@@ -64,19 +64,6 @@ MCAsmInfo::MCAsmInfo() {
     SupportsExtendedDwarfLocDirective = DwarfExtendedLoc == Enable;
   if (UseLEB128Directives != cl::BOU_UNSET)
     HasLEB128Directives = UseLEB128Directives == cl::BOU_TRUE;
-
-  // FIXME: Clang's logic should be synced with the logic used to initialize
-  //        this member and the two implementations should be merged.
-  // For reference:
-  // - Solaris always enables the integrated assembler by default
-  //   - SparcELFMCAsmInfo and X86ELFMCAsmInfo are handling this case
-  // - Windows always enables the integrated assembler by default
-  //   - MCAsmInfoCOFF is handling this case, should it be MCAsmInfoMicrosoft?
-  // - MachO targets always enables the integrated assembler by default
-  //   - MCAsmInfoDarwin is handling this case
-  // - Generic_GCC toolchains enable the integrated assembler on a per
-  //   architecture basis.
-  //   - The target subclasses for AArch64, ARM, and X86 handle these cases
   UseIntegratedAssembler = true;
   ParseInlineAsmUsingAsmParser = false;
   PreserveAsmComments = true;


        


More information about the llvm-commits mailing list