[PATCH] D158589: [MIPS] Add handing of forbidden slot when IR with inline asm

Jiaxun Yang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 23:45:34 PDT 2023


FlyGoat added a comment.

In D158589#4612830 <https://reviews.llvm.org/D158589#4612830>, @jrtc27 wrote:

> With the exception of 5, these all sound like garbage inline asm input? If you have a dangling delay slot at the end of the inline assembly, that's your problem, not the compiler's. And don't we default to reorder, anyway, so the only way to write that is to first .set noreorder?

Well forbidden slot works differs from delay slot. It is introduced in MIPS Release 6.
It does not change execution flow. It simply disallows some CTI instructions (namely branch etc) to be placed after a branch.
Requiring user to fill nop after all inline assembly that ends with those branch instructions sounds appealing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158589/new/

https://reviews.llvm.org/D158589



More information about the llvm-commits mailing list