[PATCH] D158575: [RISCV] Delete deprecated attributes

Xiao Zeng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 19:16:05 PDT 2023


zeng-xiao added a comment.

In D158575#4610925 <https://reviews.llvm.org/D158575#4610925>, @MaskRay wrote:

>> Updating D158575 <https://reviews.llvm.org/D158575>: [RISCV] Delete deprecated attributes
>
> I think this patch should be abandoned. We need test coverage for the assembler and the linker. When I added the support to lld/ELF, I intentionally kept the deprecated cases
>
>     // Attributes which use the default handling.
>   case RISCVAttrs::PRIV_SPEC:
>   case RISCVAttrs::PRIV_SPEC_MINOR:
>   case RISCVAttrs::PRIV_SPEC_REVISION:
>
> to make it clear we need to support object files using them.

Okay, thank you. I will discard this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158575/new/

https://reviews.llvm.org/D158575



More information about the llvm-commits mailing list