[PATCH] D158575: [RISCV] Delete deprecated attributes

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 11:08:38 PDT 2023


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

> Updating D158575 <https://reviews.llvm.org/D158575>: [RISCV] Delete deprecated attributes

I think this patch should be abandoned. We need test coverage for the assembler and the linker. When I added the support to lld/ELF, I intentionally kept the deprecated cases

    // Attributes which use the default handling.
  case RISCVAttrs::PRIV_SPEC:
  case RISCVAttrs::PRIV_SPEC_MINOR:
  case RISCVAttrs::PRIV_SPEC_REVISION:

to make it clear we need to support object files using them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158575/new/

https://reviews.llvm.org/D158575



More information about the llvm-commits mailing list