[PATCH] D157802: [JITLink][EHFrameSupport] Accept multiple relocations

Wed Aug 23 09:30:47 PDT 2023

lhames added a comment.

In D157802#4609098 <https://reviews.llvm.org/D157802#4609098>, @Hahnfeld wrote:

> In D157802#4599440 <https://reviews.llvm.org/D157802#4599440>, @lhames wrote:
>
>> In D157802#4588857 <https://reviews.llvm.org/D157802#4588857>, @Hahnfeld wrote:
>>
>>> No, it doesn't work - we need it to add an edge of type `NegDelta32` to the CIE. The other two relocations are indeed not needed. So we refactor that part out into a separate pass?
>>
>> Yeah -- I think that's a reasonable solution. `AddFDEToCIEEdges`?
>
> FYI I won't have time to work on this before September, so feel free to beat me to this refactoring ;-)

I'm not likely to get to it either, unfortunately. The next few months will be very busy with other work.

I would love to talk to you about the broader LinkGraph / edge design problem at some point. You're not coming to the LLVM Dev Meeting in Santa Clara are you?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157802/new/

https://reviews.llvm.org/D157802