[PATCH] D157802: [JITLink][EHFrameSupport] Accept multiple relocations

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 23:47:55 PDT 2023


Hahnfeld added a comment.

In D157802#4599440 <https://reviews.llvm.org/D157802#4599440>, @lhames wrote:

> In D157802#4588857 <https://reviews.llvm.org/D157802#4588857>, @Hahnfeld wrote:
>
>> No, it doesn't work - we need it to add an edge of type `NegDelta32` to the CIE. The other two relocations are indeed not needed. So we refactor that part out into a separate pass?
>
> Yeah -- I think that's a reasonable solution. `AddFDEToCIEEdges`?

FYI I won't have time to work on this before September, so feel free to beat me to this refactoring ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157802/new/

https://reviews.llvm.org/D157802



More information about the llvm-commits mailing list