[PATCH] D157740: [WIP] [InstCombine] Fold icmp into phi beyond the same BB.
Andrew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 23 08:59:53 PDT 2023
browneee requested changes to this revision.
browneee added inline comments.
This revision now requires changes to proceed.
================
Comment at: compiler-rt/test/dfsan/conditional_callbacks.c:101
int tainted_cond = ((DataI * DataJ) != 1);
+ dfsan_set_label(LabelIJ, &tainted_cond, sizeof(tainted_cond));
assert(dfsan_get_label(tainted_cond) == LabelIJ);
----------------
Thanks nikic and bipmis for checking this change with me :)
The point of the test is that tainted_cond should have taint labels propagated from above. This change would invalidate this test, and break the behavior this is testing for.
I wonder, what is the IR for `((DataI * DataJ) != 1)` before and after this change? I suspect this is where the taint label is being lost.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157740/new/
https://reviews.llvm.org/D157740
More information about the llvm-commits
mailing list