[PATCH] D157740: [WIP] [InstCombine] Fold icmp into phi beyond the same BB.

Biplob Mishra via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 08:45:22 PDT 2023


bipmis updated this revision to Diff 552728.
bipmis added reviewers: browneee, MaskRay.
bipmis added a comment.
This revision now requires review to proceed.
Herald added subscribers: Sanitizers, Enna1.
Herald added a project: Sanitizers.

Updating patch to handle the dfsan compiler-rt test case.

dfsan failure in pre-merge checks is legitimate. Looks like the first branch is being optimized out based on the proposed change. assert added to avoid it.
Additionally dfsan_set_label(LabelIJ..) has been added. This handles the original and latest changes in the code correctly.  I could be wrong. Would be good to have check if the changes looks correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157740/new/

https://reviews.llvm.org/D157740

Files:
  compiler-rt/test/dfsan/conditional_callbacks.c
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/test/Transforms/InstCombine/icmp-constant-phi.ll
  llvm/test/Transforms/InstCombine/phi.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157740.552728.patch
Type: text/x-patch
Size: 6199 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230823/18fb710b/attachment.bin>


More information about the llvm-commits mailing list