[PATCH] D156505: [AArch64][ELF] Support R_AARCH64_AUTH_ABS64 static relocation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/MC/AArch64/elf-reloc-ptrauth.s:86
+
+.ifdef MCONLY
+
----------------
By MCONLY you mean this is only used for `-filetype=asm` (default for llvm-mc)? I think using "MC" in this context is confusing.

`ASMONLY` may be better since -filetype=asm uses MCAsmStreamer, different from MCObjectStreamer used by -filetype=obj.


================
Comment at: llvm/test/MC/AArch64/elf-reloc-ptrauth.s:99
+.quad _g11 at AUTH(ia,42) + _g12 at AUTH(ia,42)
+
+.endif // MCONLY
----------------
An subtraction expression test will be interesting as well.

The addition of two non-absolute symbols cannot be represented in the relocatable object file while the subtractions can often be represented. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156505/new/

https://reviews.llvm.org/D156505