[PATCH] D156505: [AArch64][ELF] Support R_AARCH64_AUTH_ABS64 static relocation

Daniil Kovalev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 18:47:21 PDT 2023


kovdan01 marked 2 inline comments as done.
kovdan01 added inline comments.


================
Comment at: llvm/docs/PointerAuth.md:308
+[Authenticated Relocations](#authenticated-global-relocation) are represented
+using the ``@AUTH`` modifier:
+
----------------
MaskRay wrote:
> kovdan01 wrote:
> > MaskRay wrote:
> > > This file is a Markdown. Single backquotes are more commonly used.
> > I agree with that, but double backquotes are already used in other places in this file.
> > I suggest to leave this 'as is' in context of current patch and submit a small subsequent patch changing double- to single backquote all over the file.
> Adding double quotes than applying another patch changing double quotes to single quotes is not a good idea.
> We can add single quotes directly.
> 
> The existing places can be fixed separately. I shall also mention that `.rst` is more commonly used and helps cross-doc links.
OK, changed to single-quotes. After this lands, I'll send an NFC patch changing double-quotes in other places in this file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156505/new/

https://reviews.llvm.org/D156505



More information about the llvm-commits mailing list