[PATCH] D158379: [RISCV] Add bounds check before use on returned iterator during frame lowering.

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 21 21:02:48 PDT 2023


wangpc requested changes to this revision.
wangpc added a comment.
This revision now requires changes to proceed.

In D158379#4602317 <https://reviews.llvm.org/D158379#4602317>, @anmolparalkar-nxp wrote:

> In D158379#4602315 <https://reviews.llvm.org/D158379#4602315>, @craig.topper wrote:
>
>> Is this the same as D158256 <https://reviews.llvm.org/D158256>?
>
> Oh, Vow, thank you! Yes, the change to llvm/lib/Target/RISCV/RISCVFrameLowering.cpp is identical indeed.
> The test case, is derived using bugpoint, on an internal benchmark.

Can we merge these two patches into one? You can add tests in this patch to D158256 <https://reviews.llvm.org/D158256> and close this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158379/new/

https://reviews.llvm.org/D158379



More information about the llvm-commits mailing list