[PATCH] D158483: [CMake] Pass doc-related LLVM variables to external projects

Will Hawkins via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 21 20:59:41 PDT 2023


hawkinsw created this revision.
hawkinsw added reviewers: phosek, beanz.
Herald added a subscriber: ekilmer.
Herald added a project: All.
hawkinsw requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When generating the configuration arguments for external projects,
some of the external-project-specific CMake variables only work
in combination with CMake variables from LLVM itself. In particular,
the some of the doc-related CMake variables in libcxx depend on
LLVM_ENABLE_SPHINX. Pass

LLVM_ENABLE_SPHINX
LLVM_BUILD_DOCS

to external projects.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158483

Files:
  llvm/cmake/modules/LLVMExternalProjectUtils.cmake


Index: llvm/cmake/modules/LLVMExternalProjectUtils.cmake
===================================================================
--- llvm/cmake/modules/LLVMExternalProjectUtils.cmake
+++ llvm/cmake/modules/LLVMExternalProjectUtils.cmake
@@ -344,6 +344,8 @@
                -DPACKAGE_VERSION=${PACKAGE_VERSION}
                -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
                -DCMAKE_MAKE_PROGRAM=${CMAKE_MAKE_PROGRAM}
+               -DLLVM_ENABLE_SPHINX=${LLVM_ENABLE_SPHINX}
+               -DLLVM_BUILD_DOCS=${LLVM_BUILD_DOCS}
                -DCMAKE_EXPORT_COMPILE_COMMANDS=1
                ${cmake_args}
                ${PASSTHROUGH_VARIABLES}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158483.552203.patch
Type: text/x-patch
Size: 653 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230822/a2fbbbc5/attachment.bin>


More information about the llvm-commits mailing list