[PATCH] D156767: [AArch64] [BranchRelaxation] Optimize for hot code size in AArch64 branch relaxation

Daniel Hoekwater via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 21 09:04:10 PDT 2023


dhoekwater added inline comments.


================
Comment at: llvm/lib/CodeGen/BranchRelaxation.cpp:549
   if (!RestoreBB->empty()) {
+    if (MBB->getSectionID() == MBBSectionID::ColdSectionID && MBB &&
+        DestBB->getSectionID() != MBBSectionID::ColdSectionID) {
----------------
arsenm wrote:
> Broken MBB check, MBB cannot be null
Ah, debugging change, I'm not sure how this made it in. Thanks for the feedback.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156767/new/

https://reviews.llvm.org/D156767



More information about the llvm-commits mailing list