[PATCH] D158366: [DAG] replaceStoreOfInsertLoad - don't fold if the inserted element is implicity truncated

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:20514
   EVT EltVT = Elt.getValueType();
-  if (!EltVT.isByteSized())
+  if (!EltVT.isByteSized() || EltVT != Value.getOperand(0).getValueType())
     return SDValue();
----------------
jacobly wrote:
> `EltVT` is the scalar type being inserted, but operand 0 is the vector being inserted into, so these types can never be equal.  Maybe `EltVT != Value.getOperand(0).getValueType().getVectorElementType()`?
Sorry about that :) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158366/new/

https://reviews.llvm.org/D158366