[PATCH] D158359: [AMDGPU] Adjust swdev373493.ll to remove reduced switch undef instruction

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 20 04:59:38 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/swdev373493.ll:6
 
-define hidden fastcc void @bar(i32 %arg, ptr %arg1, ptr %arg2, ptr %arg3, ptr %arg4, ptr %arg5, ptr %arg6) unnamed_addr align 2 {
+define amdgpu_gfx void @bar(i32 %arg, ptr %arg1, ptr %arg2, ptr %arg3, ptr %arg4, ptr %arg5, ptr %arg6, i32 inreg %arg7) unnamed_addr align 2 {
 ; CHECK-LABEL: bar:
----------------
Should keep the hidden 


================
Comment at: llvm/test/CodeGen/AMDGPU/swdev373493.ll:17
+; CHECK-NEXT:    v_writelane_b32 v40, s5, 1
+; CHECK-NEXT:    v_writelane_b32 v40, s6, 2
+; CHECK-NEXT:    v_writelane_b32 v40, s7, 3
----------------
All this new spilling is suspicious. Does it go away if you use a load from constant global variable instead of the calling convention change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158359/new/

https://reviews.llvm.org/D158359



More information about the llvm-commits mailing list