[PATCH] D157828: [RISCV][GISel] Initial legalization support for G_LOAD and G_STORE.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-load.mir:6
+--- |
+  define i8 @load_i8(ptr %x) {
+    %a = load i8, ptr %x, align 1
----------------
nitinjohnraj wrote:
> craig.topper wrote:
> > nitinjohnraj wrote:
> > > Do we need the LLVM IR to specify the alignment here? Other RISCV legalizer tests don't have the LLVM IR, so I'm wondering if we can get rid of it.
> > Did someone ask for the IR to be removed in other legalizer tests or is just something we started doing without discussion?
> I believe @arsenm asked for it to be removed on Lewis' original patches. https://reviews.llvm.org/D76354#inline-1124225
The IR section is pure noise in nearly all situations, especially legalizer tests. It's an infrastructure failing that it gets printed at all in most situations


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157828/new/

https://reviews.llvm.org/D157828