[PATCH] D157828: [RISCV][GISel] Initial legalization support for G_LOAD and G_STORE.

[Nitin John Raj via Phabricator via llvm-commits]

nitinjohnraj accepted this revision.
nitinjohnraj added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: sunshaoce.

Perhaps we want to remove the llvm IR from the tests, but since that's not a functional change, LGTM.



================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-load.mir:6
+--- |
+  define i8 @load_i8(ptr %x) {
+    %a = load i8, ptr %x, align 1
----------------
craig.topper wrote:
> nitinjohnraj wrote:
> > Do we need the LLVM IR to specify the alignment here? Other RISCV legalizer tests don't have the LLVM IR, so I'm wondering if we can get rid of it.
> Did someone ask for the IR to be removed in other legalizer tests or is just something we started doing without discussion?
I believe @arsenm asked for it to be removed on Lewis' original patches. https://reviews.llvm.org/D76354#inline-1124225


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157828/new/

https://reviews.llvm.org/D157828