[PATCH] D157495: [WIP] Run SimplifyCFG from Atomic-Expand on CAS loop blocks.
Pravin Jagtap via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 18 07:49:33 PDT 2023
pravinjagtap added a comment.
Do you want me to update the patch without AArch64 atomic tidy options ? I think, relying on default options of `simplifyCFG` is good option here.
================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:361
+ for (BasicBlock *BB : CmpXchgLoopBlocks) {
+ simplifyCFG(BB, *TTI, RequireAndPreserveDomTree ? &DTU : nullptr,
+ SimplifyCFGOptions()
----------------
arsenm wrote:
> Why is RequireAndPreserveDomTree a cl:opt?
> Why is RequireAndPreserveDomTree a cl:opt?
This is based on usage of `simplifyCFG` in https://github.com/llvm/llvm-project/blob/851c248dfcdbf52ee88e4643e59453fcc13501d5/llvm/lib/Target/AMDGPU/AMDGPUUnifyDivergentExitNodes.cpp#L185
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157495/new/
https://reviews.llvm.org/D157495
More information about the llvm-commits
mailing list