[PATCH] D157495: [WIP] Run SimplifyCFG from Atomic-Expand on CAS loop blocks.

[Pravin Jagtap via Phabricator via llvm-commits]

pravinjagtap added a comment.

In D157495#4598794 <https://reviews.llvm.org/D157495#4598794>, @pravinjagtap wrote:

> In D157495#4598719 <https://reviews.llvm.org/D157495#4598719>, @arsenm wrote:
>
>> In D157495#4598715 <https://reviews.llvm.org/D157495#4598715>, @pravinjagtap wrote:
>>
>>> In D157495#4598667 <https://reviews.llvm.org/D157495#4598667>, @arsenm wrote:
>>>
>>>> In D157495#4598420 <https://reviews.llvm.org/D157495#4598420>, @pravinjagtap wrote:
>>>>
>>>>> addressed review comment
>>>>
>>>> Haven't tried to delete the AArch64 atomic tidy?
>>>
>>> TBH, I am not sure how to exactly achieve this.
>>
>> Delete the option and run of the pass and see if it's equivalently effective in the existing tests to this
>
> You mean instead of
>
>   simplifyCFG(BB, *TTI, RequireAndPreserveDomTree ? &DTU : nullptr,
>               SimplifyCFGOptions()
>                   .forwardSwitchCondToPhi(true)
>                   .convertSwitchRangeToICmp(true)
>                   .convertSwitchToLookupTable(true)
>                   .needCanonicalLoops(false)
>                   .hoistCommonInsts(true)
>                   .sinkCommonInsts(true));
>
> just call simplifyCFG(BB, TTI) ?

Output is identical without these options for the test in expand-atomic-simplify-cfg-CAS-block.ll.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157495/new/

https://reviews.llvm.org/D157495