[PATCH] D158256: [RISCV] Fix assertion failure when zcmp extension is enabled.

garvit gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 00:58:15 PDT 2023


garvitgupta08 created this revision.
garvitgupta08 added reviewers: asb, craig.topper.
Herald added subscribers: jobnoorman, luke, sunshaoce, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson.
Herald added a project: All.
garvitgupta08 requested review of this revision.
Herald added subscribers: llvm-commits, wangpc, eopXD, MaskRay.
Herald added a project: LLVM.

Before accessing "getOpcode" thorugh machine instruction, check if the iterator
has reached the end of Machine basic block otherwise we will crash at the
assertion `!NodePtr->isKnownSentinel()`.

The above assertion is hit in "Prologue/Epilogue Insertion & Frame Finalization
pass".


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158256

Files:
  llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
  llvm/test/CodeGen/RISCV/prolog-epilog-crash.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158256.551414.patch
Type: text/x-patch
Size: 8399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230818/cb22df77/attachment.bin>


More information about the llvm-commits mailing list