[PATCH] D153517: [AMDGPU] ISel for amdgpu_cs_chain[_preserve] functions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 06:06:26 PDT 2023


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with assert dropped



================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:89-90
+  if (AMDGPU::isChainCC(CC)) {
+    assert(AMDGPU::isGFX10Plus(ST) &&
+           "Chain calling conventions not supported on GFX < 10");
+
----------------
Just remove the assert, I don't see anything actually preventing usage right now pre-gfx9 and this would need to be a proper error


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153517/new/

https://reviews.llvm.org/D153517



More information about the llvm-commits mailing list